HDDS-15634. Avoid updating container delete transaction ID on SCM delete log append#10566
Open
xichen01 wants to merge 3 commits into
Open
HDDS-15634. Avoid updating container delete transaction ID on SCM delete log append#10566xichen01 wants to merge 3 commits into
xichen01 wants to merge 3 commits into
Conversation
xichen01
changed the title
ivandika3
reviewed
Jun 22, 2026
Contributor
There was a problem hiding this comment.
Thanks @xichen01 . Overall LGTM.
How about we deprecate the ContainerInfo deleteTransactionId entirely by marking proto and fields to be deprecated and adding some comments? Also we might just remove the ContainerManager#updateDeleteTransactionId
…ManagerImpl#updateDeleteTransactionId
Contributor
Author
deprecate ContainerInfo deleteTransactionId and ContainerStateManagerImpl#updateDeleteTransactionId |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reduce long-tail latency of OM allocateBlock
When SCM handles
DeleteScmKeyBlocksrequests,AllocateScmBlockcan see high tail latency becauseSequenceIdGenerator#getNextIdwaits forSCMStateMachineto finish applying DeleteScmKeyBlocks'sDeletedBlockLogStateManagerImpl#addTransactionsToDB.Profiling shows a large part of
DeletedBlockLogStateManagerImpl#addTransactionsToDBtime is spent updating SCM-sideContainerInfo#deleteTransactionId.This field is not used by current SCM business logic, while DN-side delete transaction tracking is maintained independently.
This commit removes the SCM-side
ContainerInfo#deleteTransactionIdupdate fromaddTransactionsToDBto reduce unnecessary StateMachine apply work and improve write tail latency.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15634
How was this patch tested?
existing test
https://github.com/xichen01/ozone/actions/runs/27909174625